Python integration #317
Python integration #317
Conversation
|
CI needs to be updated |
| let ARCtrl_generate (rootPath: string) = | ||
| generateIndexFileContent classes | ||
| |> Array.reduce (fun a b -> a + "\n" + b) | ||
| |> writePyIndexfile rootPath |
build/ProjectInfo.fs
Outdated
| @@ -30,8 +30,9 @@ let gitHome = $"https://github.com/{gitOwner}" | |||
|
|
|||
| let projectRepo = $"https://github.com/{gitOwner}/{project}" | |||
|
|
|||
| let pkgDir = "dist/pkg" | |||
| let netPkgDir = "dist/pkg" | |||
pyproject.toml
Outdated
| name = "ARCtrl" | ||
| version = "1.0.0" | ||
| description = "Library for management of Annotated Research Contexts (ARCs) using an in-memory representation and runtimer agnostic contract systems." | ||
| authors = ["Heinrich Lukas Weil <[email protected]>"] |
pytests/arc_table_tests.ipynb
Outdated
There was a problem hiding this comment.
Should this file be on .gitignore?
There was a problem hiding this comment.
Badly worded. I mean should this file be pushed or was it just for testing?
There was a problem hiding this comment.
Removed the whole folder and setup file. Was there for initial testing
pytests/composite_header_tests.ipynb
Outdated
| @@ -160,7 +160,7 @@ module ArcTableExtensions = | |||
|
|
|||
| member this.ToCompressedJsonString(?spaces) : string = | |||
| let spaces = defaultArg spaces 0 | |||
| let stringTable = Dictionary() | |||
| let stringTable = Dictionary() | |||
src/ISA/ISA/Fable.fs
Outdated
| let sort (a : 'T []) = | ||
| #if FABLE_COMPILER_PYTHON | ||
| a |> List.ofArray |> List.sort |> Array.ofList |
There was a problem hiding this comment.
This 100% requires a comment explaining this
There was a problem hiding this comment.
Seems to be fixed now.
| @@ -75,6 +75,26 @@ module ResizeArray = | |||
| a.Count = 0 | |||
|
|
|||
| module HashCodes = | |||
|
|
|||
| open Fable.Core | |||
|
|
|||
There was a problem hiding this comment.
comment explaining this. Is this related to an open issue on Fable-compiler?
There was a problem hiding this comment.
Will open up an issue on this in Fable. Some problem with Hash overrides and Record Types.
testpy.cmd
Outdated
There was a problem hiding this comment.
Should this file be committed?
| @@ -282,9 +282,19 @@ let tests_ArcAssay = testList "ArcAssay" [ | |||
| for j = 0 to cells.Length - 1 do | |||
| t.Values.[(j,i)] <- cells.[j] | |||
| let f() = ArcAssay.toJsonString a | |||
| #if FABLE_COMPILER_JAVASCRIPT | |||
There was a problem hiding this comment.
better:
let expectedMs =
#if FABLE_COMPILER_JAVASCRIPT
5000
#endif
#if FABLE_COMPILER_PYTHON
100000
#endif
#if !FABLE_COMPILER
2500
#endifThere was a problem hiding this comment.
Will move all of this into a performance checking project anyways.
including python release
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "@nfdi4plants/arctrl", | |||
| "version": "1.1.0+6309e03", | |||
| "version": "1.2.0+19d850e", | |||
There was a problem hiding this comment.
use short semver without metadata
|
Done, will be updated with next version tick. |
buildandtesttargets forPythonPython